Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

i2c: dev: prevent integer overflow in I2C_TIMEOUT ioctl

While fuzzing with Syzkaller, a persistent `schedule_timeout: wrong
timeout value` warning was observed, accompanied by SMBus controller
state machine corruption.

The I2C_TIMEOUT ioctl accepts a user-provided timeout in multiples of
10 ms. The user argument is checked against INT_MAX, but it is
subsequently multiplied by 10 before being passed to msecs_to_jiffies().

A malicious user can pass a large value (e.g., 429496729) that passes
the `arg > INT_MAX` check but overflows when multiplied by 10. This
results in a truncated 32-bit unsigned value that bypasses the
internal `(int)m < 0` check in `msecs_to_jiffies()`.

The truncated value is then assigned to `client->adapter->timeout`
(a signed 32-bit int), which is reinterpreted as a negative number.
When passed to wait_for_completion_timeout(), this negative value
undergoes sign extension to a 64-bit unsigned long, triggering the
`schedule_timeout` warning and causing premature returns. This leaves
the SMBus state machine in an unrecoverable state, constituting a
local Denial of Service (DoS).

Fix this by bounding the user argument to `INT_MAX / 10`.

Signed-off-by: Mingyu Wang <25181214217@stu.xidian.edu.cn>
[wsa: move the comment as well]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

authored by

Mingyu Wang and committed by
Wolfram Sang
617eb7c0 9998e388

+5 -4
+5 -4
drivers/i2c/i2c-dev.c
··· 487 487 client->adapter->retries = arg; 488 488 break; 489 489 case I2C_TIMEOUT: 490 - if (arg > INT_MAX) 490 + /* 491 + * For historical reasons, user-space sets the timeout value in 492 + * units of 10 ms. 493 + */ 494 + if (arg > INT_MAX / 10) 491 495 return -EINVAL; 492 496 493 - /* For historical reasons, user-space sets the timeout 494 - * value in units of 10 ms. 495 - */ 496 497 client->adapter->timeout = msecs_to_jiffies(arg * 10); 497 498 break; 498 499 default: