tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: qcom: qmp-combo: correct bias0_en programming

It seems the commit a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp
USB/DP combo phys") contained a typo for selecting bias0_en values.
First, bias0_en and bias1_en are expected to be symmetrical, and then
the vendor driver also uses `flipped : 0x3E : 0x15` statement for
bias0_en. Correct bias0_en programming to follow this.

Fixes: 49742e9edab3 ("phy: qcom-qmp-combo: Add support for SM8550")
Fixes: a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230621153317.1025914-2-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Dmitry Baryshkov and committed by
Vinod Koul 6292fd92 25d70083

+2 -2
+2 -2
drivers/phy/qualcomm/phy-qcom-qmp-combo.c
··· 2322 2322 return ret; 2323 2323 2324 2324 if (dp_opts->lanes == 1) { 2325 - bias0_en = reverse ? 0x3e : 0x1a; 2325 + bias0_en = reverse ? 0x3e : 0x15; 2326 2326 drvr0_en = reverse ? 0x13 : 0x10; 2327 2327 bias1_en = reverse ? 0x15 : 0x3e; 2328 2328 drvr1_en = reverse ? 0x10 : 0x13; ··· 2382 2382 return ret; 2383 2383 2384 2384 if (dp_opts->lanes == 1) { 2385 - bias0_en = reverse ? 0x3e : 0x1a; 2385 + bias0_en = reverse ? 0x3e : 0x15; 2386 2386 drvr0_en = reverse ? 0x13 : 0x10; 2387 2387 bias1_en = reverse ? 0x15 : 0x3e; 2388 2388 drvr1_en = reverse ? 0x10 : 0x13;