tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dt-bindings: dma: apple,admac: Fix example interrupt parsing

Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning
in its example:

Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@238200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml

The problem is the number of interrupt cells can't be guessed when
there are empty '0' entries. So the example must have a valid interrupt
controller defining the number of interrupt cells.

Fixes: 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC")
Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20220614152503.1410755-1-robh@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Rob Herring and committed by
Vinod Koul 62c427ca c9357195

+5
+5
Documentation/devicetree/bindings/dma/apple,admac.yaml
··· 63 63 #include <dt-bindings/interrupt-controller/apple-aic.h> 64 64 #include <dt-bindings/interrupt-controller/irq.h> 65 65 66 + aic: interrupt-controller { 67 + interrupt-controller; 68 + #interrupt-cells = <3>; 69 + }; 70 + 66 71 admac: dma-controller@238200000 { 67 72 compatible = "apple,t8103-admac", "apple,admac"; 68 73 reg = <0x38200000 0x34000>;