tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crypto: tcrypt - remove mode=1000

The lists of algothms checked for existence by
modprobe tcrypt mode=1000
generates three bogus errors:
modprobe tcrypt mode=1000

console log:
tcrypt: alg rot13 not found
tcrypt: alg cts not found
tcrypt: alg arc4 not found

rot13 is not an algorithm in the crypto API or tested.

cts is a wrapper, not a base algorithm.

arc4 is named ecb(arc4), not arc4.

Also, the list is missing numerous algorithms that are tested by
other test modes:
blake2b-512
blake2s-256
crct10dif
xxhash64
ghash
cast5
sm4
ansi_prng

Several of the algorithms are only available if
CONFIG_CRYPTO_USER_API_ENABLE_OBSOLETE is enabled:
arc4
khazad
seed
tea, xtea, xeta

Rather that fix that list, remove test mode=1000 entirely.
It seems to have limited utility, and a web search shows no
discussion of anybody using it.

Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Robert Elliott <elliott@hpe.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Robert Elliott and committed by
Herbert Xu 6363d81b 50100770

-27
-27
crypto/tcrypt.c
··· 66 66 static unsigned int klen; 67 67 static char *tvmem[TVMEMSIZE]; 68 68 69 - static const char *check[] = { 70 - "des", "md5", "des3_ede", "rot13", "sha1", "sha224", "sha256", "sm3", 71 - "blowfish", "twofish", "serpent", "sha384", "sha512", "md4", "aes", 72 - "cast6", "arc4", "michael_mic", "deflate", "crc32c", "tea", "xtea", 73 - "khazad", "wp512", "wp384", "wp256", "xeta", "fcrypt", 74 - "camellia", "seed", "rmd160", "aria", 75 - "lzo", "lzo-rle", "cts", "sha3-224", "sha3-256", "sha3-384", 76 - "sha3-512", "streebog256", "streebog512", 77 - NULL 78 - }; 79 - 80 69 static const int block_sizes[] = { 16, 64, 128, 256, 1024, 1420, 4096, 0 }; 81 70 static const int aead_sizes[] = { 16, 64, 256, 512, 1024, 1420, 4096, 8192, 0 }; 82 71 ··· 1441 1452 { 1442 1453 return test_skcipher_speed(algo, enc, secs, template, tcount, keysize, 1443 1454 false); 1444 - } 1445 - 1446 - static void test_available(void) 1447 - { 1448 - const char **name = check; 1449 - 1450 - while (*name) { 1451 - printk("alg %s ", *name); 1452 - printk(crypto_has_alg(*name, 0, 0) ? 1453 - "found\n" : "not found\n"); 1454 - name++; 1455 - } 1456 1455 } 1457 1456 1458 1457 static inline int tcrypt_test(const char *alg) ··· 2835 2858 speed_template_8_32, num_mb); 2836 2859 test_mb_skcipher_speed("ctr(blowfish)", DECRYPT, sec, NULL, 0, 2837 2860 speed_template_8_32, num_mb); 2838 - break; 2839 - 2840 - case 1000: 2841 - test_available(); 2842 2861 break; 2843 2862 } 2844 2863