tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

rust: start supporting several compiler versions

It is time to start supporting several Rust compiler versions and thus
establish a minimum Rust version.

We may still want to upgrade the minimum sometimes in the beginning since
there may be important features coming into the language that improve
how we write code (e.g. field projections), which may or may not make
sense to support conditionally.

We will start with a window of two stable releases, and widen it over
time. Thus this patch does not move the current minimum (1.78.0), but
instead adds support for the recently released 1.79.0.

This should already be enough for kernel developers in distributions that
provide recent Rust compiler versions routinely, such as Arch Linux,
Debian Unstable (outside the freeze period), Fedora Linux, Gentoo
Linux (especially the testing channel), Nix (unstable) and openSUSE
Tumbleweed. See the documentation patch about it later in this series.

In addition, Rust for Linux is now being built-tested in Rust's pre-merge
CI [1]. That is, every change that is attempting to land into the Rust
compiler is tested against the kernel, and it is merged only if it passes
-- thanks to the Rust project for that!

Thus, with the pre-merge CI in place, both projects hope to avoid
unintentional changes to Rust that break the kernel. This means that,
in general, apart from intentional changes on their side (that we will
need to workaround conditionally on our side), the upcoming Rust compiler
versions should generally work.

For instance, currently, the beta (1.80.0) and nightly (1.81.0) branches
work as well.

Of course, the Rust for Linux CI job in the Rust toolchain may still need
to be temporarily disabled for different reasons, but the intention is
to help bring Rust for Linux into stable Rust.

Link: https://github.com/rust-lang/rust/pull/125209 [1]
Reviewed-by: Finn Behrens <me@kloenk.dev>
Tested-by: Benno Lossin <benno.lossin@proton.me>
Tested-by: Andreas Hindborg <a.hindborg@samsung.com>
Link: https://lore.kernel.org/r/20240709160615.998336-7-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Miguel Ojeda 63b27f4a bb421b51

+8 -24
+1 -3
Documentation/process/changes.rst
··· 88 88 Rust (optional) 89 89 --------------- 90 90 91 - A particular version of the Rust toolchain is required. Newer versions may or 92 - may not work because the kernel depends on some unstable Rust features, for 93 - the moment. 91 + A recent version of the Rust compiler is required. 94 92 95 93 Each Rust toolchain comes with several "components", some of which are required 96 94 (like ``rustc``) and some that are optional. The ``rust-src`` component (which
+7 -8
Documentation/rust/quick-start.rst
··· 36 36 rustc 37 37 ***** 38 38 39 - A particular version of the Rust compiler is required. Newer versions may or 40 - may not work because, for the moment, the kernel depends on some unstable 41 - Rust features. 39 + A recent version of the Rust compiler is required. 42 40 43 41 If ``rustup`` is being used, enter the kernel build directory (or use 44 - ``--path=<build-dir>`` argument to the ``set`` sub-command) and run:: 42 + ``--path=<build-dir>`` argument to the ``set`` sub-command) and run, 43 + for instance:: 45 44 46 - rustup override set $(scripts/min-tool-version.sh rustc) 45 + rustup override set stable 47 46 48 - This will configure your working directory to use the correct version of 47 + This will configure your working directory to use the given version of 49 48 ``rustc`` without affecting your default toolchain. 50 49 51 50 Note that the override applies to the current working directory (and its ··· 71 72 Otherwise, if a standalone installer is used, the Rust source tree may be 72 73 downloaded into the toolchain's installation folder:: 73 74 74 - curl -L "https://static.rust-lang.org/dist/rust-src-$(scripts/min-tool-version.sh rustc).tar.gz" | 75 + curl -L "https://static.rust-lang.org/dist/rust-src-$(rustc --version | cut -d' ' -f2).tar.gz" | 75 76 tar -xzf - -C "$(rustc --print sysroot)/lib" \ 76 - "rust-src-$(scripts/min-tool-version.sh rustc)/rust-src/lib/" \ 77 + "rust-src-$(rustc --version | cut -d' ' -f2)/rust-src/lib/" \ 77 78 --strip-components=3 78 79 79 80 In this case, upgrading the Rust compiler version later on requires manually
-8
scripts/rust_is_available.sh
··· 117 117 echo >&2 "***" 118 118 exit 1 119 119 fi 120 - if [ "$rust_compiler_cversion" -gt "$rust_compiler_min_cversion" ]; then 121 - echo >&2 "***" 122 - echo >&2 "*** Rust compiler '$RUSTC' is too new. This may or may not work." 123 - echo >&2 "*** Your version: $rust_compiler_version" 124 - echo >&2 "*** Expected version: $rust_compiler_min_version" 125 - echo >&2 "***" 126 - warning=1 127 - fi 128 120 129 121 # Check that the Rust bindings generator is suitable. 130 122 #
-5
scripts/rust_is_available_test.py
··· 193 193 result = self.run_script(self.Expected.FAILURE, { "RUSTC": rustc }) 194 194 self.assertIn(f"Rust compiler '{rustc}' is too old.", result.stderr) 195 195 196 - def test_rustc_new_version(self): 197 - rustc = self.generate_rustc("rustc 1.999.0 (a8314ef7d 2099-06-27)") 198 - result = self.run_script(self.Expected.SUCCESS_WITH_WARNINGS, { "RUSTC": rustc }) 199 - self.assertIn(f"Rust compiler '{rustc}' is too new. This may or may not work.", result.stderr) 200 - 201 196 def test_bindgen_nonexecutable(self): 202 197 result = self.run_script(self.Expected.FAILURE, { "BINDGEN": self.nonexecutable }) 203 198 self.assertIn(f"Running '{self.nonexecutable}' to check the Rust bindings generator version failed with", result.stderr)