Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
powerpc/rtas: Remove 'extern' from function declarations in rtas.h
This header occasionally gains new function declarations without the
leading extern in accordance with current style rules. Leaving the
legacy externs in place is making the header more difficult to read
over time because of the inconsistency. Remove them.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
[mpe: Add names to rtas_call() parameters]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231106-rtas-trivial-v1-7-61847655c51f@linux.ibm.com
authored by
Nathan Lynch
and committed by
Michael Ellerman
646477fc
19773eda
+26
-27
+26
-27
arch/powerpc/include/asm/rtas.h
+26
-27
arch/powerpc/include/asm/rtas.h
···
408
408
{
409
409
return rtas_function_token(handle) != RTAS_UNKNOWN_SERVICE;
410
410
}
411
-
extern int rtas_token(const char *service);
412
-
extern int rtas_call(int token, int, int, int *, ...);
411
+
int rtas_token(const char *service);
412
+
int rtas_call(int token, int nargs, int nret, int *outputs, ...);
413
413
void rtas_call_unlocked(struct rtas_args *args, int token, int nargs,
414
414
int nret, ...);
415
-
extern void __noreturn rtas_restart(char *cmd);
416
-
extern void rtas_power_off(void);
417
-
extern void __noreturn rtas_halt(void);
418
-
extern void rtas_os_term(char *str);
415
+
void __noreturn rtas_restart(char *cmd);
416
+
void rtas_power_off(void);
417
+
void __noreturn rtas_halt(void);
418
+
void rtas_os_term(char *str);
419
419
void rtas_activate_firmware(void);
420
-
extern int rtas_get_sensor(int sensor, int index, int *state);
421
-
extern int rtas_get_sensor_fast(int sensor, int index, int *state);
422
-
extern int rtas_get_power_level(int powerdomain, int *level);
423
-
extern int rtas_set_power_level(int powerdomain, int level, int *setlevel);
424
-
extern bool rtas_indicator_present(int token, int *maxindex);
425
-
extern int rtas_set_indicator(int indicator, int index, int new_value);
426
-
extern int rtas_set_indicator_fast(int indicator, int index, int new_value);
427
-
extern void rtas_progress(char *s, unsigned short hex);
420
+
int rtas_get_sensor(int sensor, int index, int *state);
421
+
int rtas_get_sensor_fast(int sensor, int index, int *state);
422
+
int rtas_get_power_level(int powerdomain, int *level);
423
+
int rtas_set_power_level(int powerdomain, int level, int *setlevel);
424
+
bool rtas_indicator_present(int token, int *maxindex);
425
+
int rtas_set_indicator(int indicator, int index, int new_value);
426
+
int rtas_set_indicator_fast(int indicator, int index, int new_value);
427
+
void rtas_progress(char *s, unsigned short hex);
428
428
int rtas_ibm_suspend_me(int *fw_status);
429
429
int rtas_error_rc(int rtas_rc);
430
430
431
431
struct rtc_time;
432
-
extern time64_t rtas_get_boot_time(void);
433
-
extern void rtas_get_rtc_time(struct rtc_time *rtc_time);
434
-
extern int rtas_set_rtc_time(struct rtc_time *rtc_time);
432
+
time64_t rtas_get_boot_time(void);
433
+
void rtas_get_rtc_time(struct rtc_time *rtc_time);
434
+
int rtas_set_rtc_time(struct rtc_time *rtc_time);
435
435
436
-
extern unsigned int rtas_busy_delay_time(int status);
436
+
unsigned int rtas_busy_delay_time(int status);
437
437
bool rtas_busy_delay(int status);
438
438
439
-
extern int early_init_dt_scan_rtas(unsigned long node,
440
-
const char *uname, int depth, void *data);
439
+
int early_init_dt_scan_rtas(unsigned long node, const char *uname, int depth, void *data);
441
440
442
-
extern void pSeries_log_error(char *buf, unsigned int err_type, int fatal);
441
+
void pSeries_log_error(char *buf, unsigned int err_type, int fatal);
443
442
444
443
#ifdef CONFIG_PPC_PSERIES
445
444
extern time64_t last_rtas_event;
446
-
extern int clobbering_unread_rtas_event(void);
445
+
int clobbering_unread_rtas_event(void);
447
446
int rtas_syscall_dispatch_ibm_suspend_me(u64 handle);
448
447
#else
449
448
static inline int clobbering_unread_rtas_event(void) { return 0; }
···
453
454
#endif
454
455
455
456
#ifdef CONFIG_PPC_RTAS_DAEMON
456
-
extern void rtas_cancel_event_scan(void);
457
+
void rtas_cancel_event_scan(void);
457
458
#else
458
459
static inline void rtas_cancel_event_scan(void) { }
459
460
#endif
···
478
479
* for all rtas calls that require an error buffer argument.
479
480
* This includes 'check-exception' and 'rtas-last-error'.
480
481
*/
481
-
extern int rtas_get_error_log_max(void);
482
+
int rtas_get_error_log_max(void);
482
483
483
484
/* Event Scan Parameters */
484
485
#define EVENT_SCAN_ALL_EVENTS 0xf0000000
···
517
518
(devfn << 8) | (reg & 0xff);
518
519
}
519
520
520
-
extern void rtas_give_timebase(void);
521
-
extern void rtas_take_timebase(void);
521
+
void rtas_give_timebase(void);
522
+
void rtas_take_timebase(void);
522
523
523
524
#ifdef CONFIG_PPC_RTAS
524
525
static inline int page_is_rtas_user_buf(unsigned long pfn)
···
531
532
532
533
/* Not the best place to put pSeries_coalesce_init, will be fixed when we
533
534
* move some of the rtas suspend-me stuff to pseries */
534
-
extern void pSeries_coalesce_init(void);
535
+
void pSeries_coalesce_init(void);
535
536
void rtas_initialize(void);
536
537
#else
537
538
static inline int page_is_rtas_user_buf(unsigned long pfn) { return 0;}