tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

regulator: max14577: Add error check for max14577_read_reg()

The function max14577_reg_get_current_limit() calls the function
max14577_read_reg(), but does not check its return value. A proper
implementation can be found in max14577_get_online().

Add a error check for the max14577_read_reg() and return error code
if the function fails.

Fixes: b0902bbeb768 ("regulator: max14577: Add regulator driver for Maxim 14577")
Cc: stable@vger.kernel.org # v3.14
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20250526025627.407-1-vulab@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Wentao Liang and committed by
Mark Brown 65271f86 dcd71102

+4 -1
+4 -1
drivers/regulator/max14577-regulator.c
··· 40 40 struct max14577 *max14577 = rdev_get_drvdata(rdev); 41 41 const struct maxim_charger_current *limits = 42 42 &maxim_charger_currents[max14577->dev_type]; 43 + int ret; 43 44 44 45 if (rdev_get_id(rdev) != MAX14577_CHARGER) 45 46 return -EINVAL; 46 47 47 - max14577_read_reg(rmap, MAX14577_CHG_REG_CHG_CTRL4, &reg_data); 48 + ret = max14577_read_reg(rmap, MAX14577_CHG_REG_CHG_CTRL4, &reg_data); 49 + if (ret < 0) 50 + return ret; 48 51 49 52 if ((reg_data & CHGCTRL4_MBCICHWRCL_MASK) == 0) 50 53 return limits->min;