tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

module: Simplify warning on positive returns from module_init()

It should now be rare to trigger this warning - it doesn't need to be so
verbose. Make it follow the usual style in the module loading code.

For the same reason, drop the dump_stack().

Suggested-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

authored by

Lucas De Marchi and committed by
Sami Tolvanen 663385f9 743f8cae

+3 -7
+3 -7
kernel/module/main.c
··· 3115 3115 3116 3116 goto fail_free_freeinit; 3117 3117 } 3118 - if (ret > 0) { 3119 - pr_warn("%s: '%s'->init suspiciously returned %d, it should " 3120 - "follow 0/-E convention\n" 3121 - "%s: loading module anyway...\n", 3122 - __func__, mod->name, ret, __func__); 3123 - dump_stack(); 3124 - } 3118 + if (ret > 0) 3119 + pr_warn("%s: init suspiciously returned %d, it should follow 0/-E convention\n", 3120 + mod->name, ret); 3125 3121 3126 3122 /* Now it's a first class citizen! */ 3127 3123 mod->state = MODULE_STATE_LIVE;