Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: rdc321x: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-24-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
6645579b c5504409

+2 -4
+2 -4
drivers/watchdog/rdc321x_wdt.c
··· 257 257 return 0; 258 258 } 259 259 260 - static int rdc321x_wdt_remove(struct platform_device *pdev) 260 + static void rdc321x_wdt_remove(struct platform_device *pdev) 261 261 { 262 262 if (rdc321x_wdt_device.queue) { 263 263 rdc321x_wdt_device.queue = 0; ··· 265 265 } 266 266 267 267 misc_deregister(&rdc321x_wdt_misc); 268 - 269 - return 0; 270 268 } 271 269 272 270 static struct platform_driver rdc321x_wdt_driver = { 273 271 .probe = rdc321x_wdt_probe, 274 - .remove = rdc321x_wdt_remove, 272 + .remove_new = rdc321x_wdt_remove, 275 273 .driver = { 276 274 .name = "rdc321x-wdt", 277 275 },