Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
pwm: bcm2835: Introduce a local variable for &pdev->dev
&pdev->dev is used several times in bcm2835_pwm_probe(). Introduce a
local variable to simplify all usages.
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/3f302472e30e21c7ef5624a1d0a2890d9fdf3c7f.1710078146.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
+9
-9
+9
-9
drivers/pwm/pwm-bcm2835.c
+9
-9
drivers/pwm/pwm-bcm2835.c
···
133
133
134
134
static int bcm2835_pwm_probe(struct platform_device *pdev)
135
135
{
136
+
struct device *dev = &pdev->dev;
136
137
struct pwm_chip *chip;
137
138
struct bcm2835_pwm *pc;
138
139
int ret;
139
140
140
-
chip = devm_pwmchip_alloc(&pdev->dev, 2, sizeof(*pc));
141
+
chip = devm_pwmchip_alloc(dev, 2, sizeof(*pc));
141
142
if (IS_ERR(chip))
142
143
return PTR_ERR(chip);
143
144
pc = to_bcm2835_pwm(chip);
···
147
146
if (IS_ERR(pc->base))
148
147
return PTR_ERR(pc->base);
149
148
150
-
pc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
149
+
pc->clk = devm_clk_get_enabled(dev, NULL);
151
150
if (IS_ERR(pc->clk))
152
-
return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
151
+
return dev_err_probe(dev, PTR_ERR(pc->clk),
153
152
"clock not found\n");
154
153
155
154
ret = clk_rate_exclusive_get(pc->clk);
156
155
if (ret)
157
-
return dev_err_probe(&pdev->dev, ret,
156
+
return dev_err_probe(dev, ret,
158
157
"fail to get exclusive rate\n");
159
158
160
-
ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
159
+
ret = devm_add_action_or_reset(dev, devm_clk_rate_exclusive_put,
161
160
pc->clk);
162
161
if (ret)
163
162
return ret;
164
163
165
164
pc->rate = clk_get_rate(pc->clk);
166
165
if (!pc->rate)
167
-
return dev_err_probe(&pdev->dev, -EINVAL,
166
+
return dev_err_probe(dev, -EINVAL,
168
167
"failed to get clock rate\n");
169
168
170
169
chip->ops = &bcm2835_pwm_ops;
···
172
171
173
172
platform_set_drvdata(pdev, pc);
174
173
175
-
ret = devm_pwmchip_add(&pdev->dev, chip);
174
+
ret = devm_pwmchip_add(dev, chip);
176
175
if (ret < 0)
177
-
return dev_err_probe(&pdev->dev, ret,
178
-
"failed to add pwmchip\n");
176
+
return dev_err_probe(dev, ret, "failed to add pwmchip\n");
179
177
180
178
return 0;
181
179
}