tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Merge tag 'firewire-fixes-6.8-final' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394

Pull firewire fix from Takashi Sakamoto:
"A fix to suppress a warning about unreleased IRQ for 1394 OHCI
hardware when disabling MSI.

In Linux kernel v6.5, a PCI driver for 1394 OHCI hardware was
optimized into the managed device resources. Edmund Raile points out
that the change brings the warning about unreleased IRQ at the call of
pci_disable_msi(), since the API expects that the relevant IRQ has
already been released in advance.

As long as the API is called in .remove callback of PCI device
operation, it is prohibited to maintain the IRQ as the part of managed
device resource. As a workaround, the IRQ is explicitly released at
.remove callback, before the call of pci_disable_msi().

pci_disable_msi() is legacy API nowadays in PCI MSI implementation. I
have a plan to replace it with the modern API in the development for
the future version of Linux kernel. So at present I keep them as is"

* tag 'firewire-fixes-6.8-final' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394:
firewire: ohci: prevent leak of left-over IRQ on unbind

Linus Torvalds 66695e7d 09e5c48f

+2
+2
drivers/firewire/ohci.c
··· 3773 3773 return 0; 3774 3774 3775 3775 fail_msi: 3776 + devm_free_irq(&dev->dev, dev->irq, ohci); 3776 3777 pci_disable_msi(dev); 3777 3778 3778 3779 return err; ··· 3801 3800 3802 3801 software_reset(ohci); 3803 3802 3803 + devm_free_irq(&dev->dev, dev->irq, ohci); 3804 3804 pci_disable_msi(dev); 3805 3805 3806 3806 dev_notice(&dev->dev, "removing fw-ohci device\n");