Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm: shmem_zero_setup skip security check and lockdep conflict with XFS

It appears that, at some point last year, XFS made directory handling
changes which bring it into lockdep conflict with shmem_zero_setup():
it is surprising that mmap() can clone an inode while holding mmap_sem,
but that has been so for many years.

Since those few lockdep traces that I've seen all implicated selinux,
I'm hoping that we can use the __shmem_file_setup(,,,S_PRIVATE) which
v3.13's commit c7277090927a ("security: shmem: implement kernel private
shmem inodes") introduced to avoid LSM checks on kernel-internal inodes:
the mmap("/dev/zero") cloned inode is indeed a kernel-internal detail.

This also covers the !CONFIG_SHMEM use of ramfs to support /dev/zero
(and MAP_SHARED|MAP_ANONYMOUS). I thought there were also drivers
which cloned inode in mmap(), but if so, I cannot locate them now.

Reported-and-tested-by: Prarit Bhargava <prarit@redhat.com>
Reported-and-tested-by: Daniel Wagner <wagi@monom.org>
Reported-and-tested-by: Morten Stevens <mstevens@fedoraproject.org>
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Hugh Dickins and committed by
Linus Torvalds
66fc1303 0f57d867

+7 -1
+7 -1
mm/shmem.c
··· 3401 3401 struct file *file; 3402 3402 loff_t size = vma->vm_end - vma->vm_start; 3403 3403 3404 - file = shmem_file_setup("dev/zero", size, vma->vm_flags); 3404 + /* 3405 + * Cloning a new file under mmap_sem leads to a lock ordering conflict 3406 + * between XFS directory reading and selinux: since this file is only 3407 + * accessible to the user through its mapping, use S_PRIVATE flag to 3408 + * bypass file security, in the same way as shmem_kernel_file_setup(). 3409 + */ 3410 + file = __shmem_file_setup("dev/zero", size, vma->vm_flags, S_PRIVATE); 3405 3411 if (IS_ERR(file)) 3406 3412 return PTR_ERR(file); 3407 3413