Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

staging/octeon: fix up merge error

There's a semantic conflict in the Octeon staging network driver, which
used the skb_reset_tc() function to reset skb state when re-using an
skb. But that inline helper function was removed in mainline by commit
2c64605b590e ("net: Fix CONFIG_NET_CLS_ACT=n and
CONFIG_NFT_FWD_NETDEV={y, m} build").

Fix it by using skb_reset_redirect() instead. Also move it out of the

This code path only ends up triggering if REUSE_SKBUFFS_WITHOUT_FREE is
enabled, which in turn only happens if you don't have CONFIG_NETFILTER
configured. Which was how this wasn't caught by the usual allmodconfig
builds.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Randy Dunlap and committed by
Linus Torvalds
673b41e0 642e53ea

+1 -1
+1 -1
drivers/staging/octeon/ethernet-tx.c
··· 352 352 skb_dst_set(skb, NULL); 353 353 skb_ext_reset(skb); 354 354 nf_reset_ct(skb); 355 + skb_reset_redirect(skb); 355 356 356 357 #ifdef CONFIG_NET_SCHED 357 358 skb->tc_index = 0; 358 - skb_reset_tc(skb); 359 359 #endif /* CONFIG_NET_SCHED */ 360 360 #endif /* REUSE_SKBUFFS_WITHOUT_FREE */ 361 361