Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/i915/display_wa: Keep enum intel_display_wa sorted
For a consistent way of updating enum intel_display_wa, let's sort it by
lineage number and add a comment asking for future updates to keep it
sorted.
In the same way, let's also keep __intel_display_wa() sorted.
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patch.msgid.link/20251222-display-wa-13012396614-timing-of-mdclk-source-selection-v1-1-a2f7e9447f7a@intel.com
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
+14
-9
+6
-6
drivers/gpu/drm/i915/display/intel_display_wa.c
+6
-6
drivers/gpu/drm/i915/display/intel_display_wa.c
···
62
62
bool __intel_display_wa(struct intel_display *display, enum intel_display_wa wa, const char *name)
63
63
{
64
64
switch (wa) {
65
+
case INTEL_DISPLAY_WA_14011503117:
66
+
return DISPLAY_VER(display) == 13;
67
+
case INTEL_DISPLAY_WA_14025769978:
68
+
return DISPLAY_VER(display) == 35;
69
+
case INTEL_DISPLAY_WA_15018326506:
70
+
return display->platform.battlemage;
65
71
case INTEL_DISPLAY_WA_16023588340:
66
72
return intel_display_needs_wa_16023588340(display);
67
73
case INTEL_DISPLAY_WA_16025573575:
68
74
return intel_display_needs_wa_16025573575(display);
69
-
case INTEL_DISPLAY_WA_14011503117:
70
-
return DISPLAY_VER(display) == 13;
71
75
case INTEL_DISPLAY_WA_22014263786:
72
76
return IS_DISPLAY_VERx100(display, 1100, 1400);
73
-
case INTEL_DISPLAY_WA_15018326506:
74
-
return display->platform.battlemage;
75
-
case INTEL_DISPLAY_WA_14025769978:
76
-
return DISPLAY_VER(display) == 35;
77
77
default:
78
78
drm_WARN(display->drm, 1, "Missing Wa number: %s\n", name);
79
79
break;
+8
-3
drivers/gpu/drm/i915/display/intel_display_wa.h
+8
-3
drivers/gpu/drm/i915/display/intel_display_wa.h
···
21
21
bool intel_display_needs_wa_16023588340(struct intel_display *display);
22
22
#endif
23
23
24
+
/*
25
+
* This enum lists display workarounds; each entry here must have a
26
+
* corresponding case in __intel_display_wa(). Keep both sorted by lineage
27
+
* number.
28
+
*/
24
29
enum intel_display_wa {
30
+
INTEL_DISPLAY_WA_14011503117,
31
+
INTEL_DISPLAY_WA_14025769978,
32
+
INTEL_DISPLAY_WA_15018326506,
25
33
INTEL_DISPLAY_WA_16023588340,
26
34
INTEL_DISPLAY_WA_16025573575,
27
-
INTEL_DISPLAY_WA_14011503117,
28
35
INTEL_DISPLAY_WA_22014263786,
29
-
INTEL_DISPLAY_WA_15018326506,
30
-
INTEL_DISPLAY_WA_14025769978,
31
36
};
32
37
33
38
bool __intel_display_wa(struct intel_display *display, enum intel_display_wa wa, const char *name);