Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
selftests/bpf: Replace strcpy() calls with strscpy()
strcpy() does not perform bounds checking and is considered deprecated
[1]. Replace strcpy() calls with strscpy() defined in bpf_util.h.
[1] https://docs.kernel.org/process/deprecated.html#strcpy
Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Link: https://lore.kernel.org/r/20260223190736.649171-3-ihor.solodrai@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
authored by
Ihor Solodrai
and committed by
Alexei Starovoitov
6a087ac2
63c49efc
+8
-7
+1
-1
tools/testing/selftests/bpf/network_helpers.c
+1
-1
tools/testing/selftests/bpf/network_helpers.c
···
432
432
memset(addr, 0, sizeof(*sun));
433
433
sun->sun_family = family;
434
434
sun->sun_path[0] = 0;
435
-
strcpy(sun->sun_path + 1, addr_str);
435
+
strscpy(sun->sun_path + 1, addr_str, sizeof(sun->sun_path) - 1);
436
436
if (len)
437
437
*len = offsetof(struct sockaddr_un, sun_path) + 1 + strlen(addr_str);
438
438
return 0;
+1
-1
tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
+1
-1
tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
···
281
281
dctcp_skel = bpf_dctcp__open();
282
282
if (!ASSERT_OK_PTR(dctcp_skel, "dctcp_skel"))
283
283
return;
284
-
strcpy(dctcp_skel->rodata->fallback_cc, "cubic");
284
+
strscpy(dctcp_skel->rodata->fallback_cc, "cubic");
285
285
if (!ASSERT_OK(bpf_dctcp__load(dctcp_skel), "bpf_dctcp__load"))
286
286
goto done;
287
287
+1
-1
tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
+1
-1
tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
···
212
212
if (!ASSERT_OK_PTR(skel, "open skel"))
213
213
goto done;
214
214
215
-
strcpy(skel->rodata->veth, "binddevtest1");
215
+
strscpy(skel->rodata->veth, "binddevtest1");
216
216
skel->rodata->veth_ifindex = if_nametoindex("binddevtest1");
217
217
if (!ASSERT_GT(skel->rodata->veth_ifindex, 0, "if_nametoindex"))
218
218
goto done;
+1
-1
tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
+1
-1
tools/testing/selftests/bpf/prog_tests/sockopt_sk.c
+2
-2
tools/testing/selftests/bpf/prog_tests/test_veristat.c
+2
-2
tools/testing/selftests/bpf/prog_tests/test_veristat.c
···
24
24
25
25
/* for no_alu32 and cpuv4 veristat is in parent folder */
26
26
if (access("./veristat", F_OK) == 0)
27
-
strcpy(fix->veristat, "./veristat");
27
+
strscpy(fix->veristat, "./veristat");
28
28
else if (access("../veristat", F_OK) == 0)
29
-
strcpy(fix->veristat, "../veristat");
29
+
strscpy(fix->veristat, "../veristat");
30
30
else
31
31
PRINT_FAIL("Can't find veristat binary");
32
32
+2
-1
tools/testing/selftests/bpf/xdp_features.c
+2
-1
tools/testing/selftests/bpf/xdp_features.c
···
16
16
17
17
#include <network_helpers.h>
18
18
19
+
#include "bpf_util.h"
19
20
#include "xdp_features.skel.h"
20
21
#include "xdp_features.h"
21
22
···
213
212
env.feature.drv_feature = NETDEV_XDP_ACT_NDO_XMIT;
214
213
env.feature.action = -EINVAL;
215
214
env.ifindex = -ENODEV;
216
-
strcpy(env.ifname, "unknown");
215
+
strscpy(env.ifname, "unknown");
217
216
make_sockaddr(AF_INET6, "::ffff:127.0.0.1", DUT_CTRL_PORT,
218
217
&env.dut_ctrl_addr, NULL);
219
218
make_sockaddr(AF_INET6, "::ffff:127.0.0.1", DUT_ECHO_PORT,