tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

HID: asus: use same report_id in response

Currently, asus_kbd_get_functions prods the device using feature
report report_id, but then is hardcoded to check the response through
FEATURE_KBD_REPORT_ID. This only works if report_id is that value
(currently true). So, use report_id in the response as well to
maintain functionality if that value changes in the future.

Reviewed-by: Denis Benato <benato.denis96@gmail.com>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Link: https://patch.msgid.link/20260122075044.5070-4-lkml@antheas.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

authored by

Antheas Kapenekakis and committed by
Ilpo Järvinen 6a293b6e 4ac51daa

+1 -1
+1 -1
drivers/hid/hid-asus.c
··· 424 424 if (!readbuf) 425 425 return -ENOMEM; 426 426 427 - ret = hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf, 427 + ret = hid_hw_raw_request(hdev, report_id, readbuf, 428 428 FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT, 429 429 HID_REQ_GET_REPORT); 430 430 if (ret < 0) {