tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: pic32: fix controller deregistration

Make sure to deregister the controller before releasing underlying
resources like DMA during driver unbind.

Fixes: 1bcb9f8ceb67 ("spi: spi-pic32: Add PIC32 SPI master driver")
Cc: stable@vger.kernel.org # 4.7
Cc: Purna Chandra Mandal <purna.mandal@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260410081757.503099-7-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Johan Hovold and committed by
Mark Brown 6b627bfe fb45f95c

+8 -3
+8 -3
drivers/spi/spi-pic32.c
··· 821 821 } 822 822 823 823 /* register host */ 824 - ret = devm_spi_register_controller(&pdev->dev, host); 824 + ret = spi_register_controller(host); 825 825 if (ret) { 826 826 dev_err(&host->dev, "failed registering spi host\n"); 827 827 goto err_bailout; ··· 840 840 841 841 static void pic32_spi_remove(struct platform_device *pdev) 842 842 { 843 - struct pic32_spi *pic32s; 843 + struct pic32_spi *pic32s = platform_get_drvdata(pdev); 844 844 845 - pic32s = platform_get_drvdata(pdev); 845 + spi_controller_get(pic32s->host); 846 + 847 + spi_unregister_controller(pic32s->host); 848 + 846 849 pic32_spi_disable(pic32s); 847 850 pic32_spi_dma_unprep(pic32s); 851 + 852 + spi_controller_put(pic32s->host); 848 853 } 849 854 850 855 static const struct of_device_id pic32_spi_of_match[] = {