tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gpu: nova-core: vbios: use from_le_bytes() for PCI ROM header parsing

Clippy fires two clippy::precedence warnings on the manual
byte-shifting expression:
warning: operator precedence can trip the unwary
--> drivers/gpu/nova-core/vbios.rs:511:17
|
511 | / u32::from(data[29]) << 24
512 | | | u32::from(data[28]) << 16
513 | | | u32::from(data[27]) << 8
| |______________________________________________^

Clear the warnings by replacing manual byte-shifting with
u32::from_le_bytes(). Using from_le_bytes() is also a tiny code
improvement, because it uses less code and is clearer about the intent.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Link: https://patch.msgid.link/20260404212831.78971-2-jhubbard@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>

authored by

John Hubbard and committed by
Danilo Krummrich 6b9a10d6 de0aca13

+1 -6
+1 -6
drivers/gpu/nova-core/vbios.rs
··· 507 507 508 508 if data.len() >= 30 { 509 509 // Read size_of_block at offset 0x1A. 510 - size_of_block = Some( 511 - u32::from(data[29]) << 24 512 - | u32::from(data[28]) << 16 513 - | u32::from(data[27]) << 8 514 - | u32::from(data[26]), 515 - ); 510 + size_of_block = Some(u32::from_le_bytes([data[26], data[27], data[28], data[29]])); 516 511 } 517 512 518 513 // For NBSI images, try to read the nbsiDataOffset at offset 0x16.