tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phylink: fix SGMII inband autoneg enable

When we are operating in SGMII inband mode, it implies that there is a
PHY connected, and the ethtool advertisement for autoneg applies to
the PHY, not the SGMII link. When in 1000base-X mode, then this applies
to the 802.3z link and needs to be applied to the PCS.

Fix this.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/E1o9Ng2-005Qbe-3H@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Russell King (Oracle) and committed by
Jakub Kicinski 6d1ce9c0 40ad0a52

+3 -1
+3 -1
drivers/net/phy/phylink.c
··· 3040 3040 3041 3041 /* Ensure ISOLATE bit is disabled */ 3042 3042 if (mode == MLO_AN_INBAND && 3043 - linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising)) 3043 + (interface == PHY_INTERFACE_MODE_SGMII || 3044 + interface == PHY_INTERFACE_MODE_QSGMII || 3045 + linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising))) 3044 3046 bmcr = BMCR_ANENABLE; 3045 3047 else 3046 3048 bmcr = 0;