tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

kbuild: Fix permissions of modules.builtin.modinfo

Currently, modules.builtin.modinfo is created with executable permissions
(0755). This is because after commit 39cfd5b12160 ("kbuild: extract
modules.builtin.modinfo from vmlinux.unstripped"), modules.builtin.modinfo
is extracted from vmlinux.unstripped using objcopy. When extracting
sections, objcopy inherits attributes from the source ELF file.

Since modules.builtin.modinfo is a data file and not an executable,
it should have regular file permissions (0644). The executable bit
can trigger warnings in Debian's Lintian tool.

Explicitly remove the executable bit after generation.

Fixes: 39cfd5b12160 ("kbuild: extract modules.builtin.modinfo from vmlinux.unstripped")
Signed-off-by: Ethan Zuo <yuxuan.zuo@outlook.com>
Link: https://patch.msgid.link/SY0P300MB0609F6916B24ADF65502940B9C91A@SY0P300MB0609.AUSP300.PROD.OUTLOOK.COM
Signed-off-by: Nicolas Schier <nsc@kernel.org>

authored by

Ethan Zuo and committed by
Nicolas Schier 6d60354e 62089b80

+2 -1
+2 -1
scripts/Makefile.vmlinux
··· 113 113 # what kmod expects to parse. 114 114 quiet_cmd_modules_builtin_modinfo = GEN $@ 115 115 cmd_modules_builtin_modinfo = $(cmd_objcopy); \ 116 - sed -i 's/\x00\+$$/\x00/g' $@ 116 + sed -i 's/\x00\+$$/\x00/g' $@; \ 117 + chmod -x $@ 117 118 118 119 OBJCOPYFLAGS_modules.builtin.modinfo := -j .modinfo -O binary 119 120