tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

misc: tps6594-pfsm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230707073343.3396477-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman 6dab711d 39058419

+2 -4
+2 -4
drivers/misc/tps6594-pfsm.c
··· 281 281 return misc_register(&pfsm->miscdev); 282 282 } 283 283 284 - static int tps6594_pfsm_remove(struct platform_device *pdev) 284 + static void tps6594_pfsm_remove(struct platform_device *pdev) 285 285 { 286 286 struct tps6594_pfsm *pfsm = platform_get_drvdata(pdev); 287 287 288 288 misc_deregister(&pfsm->miscdev); 289 - 290 - return 0; 291 289 } 292 290 293 291 static struct platform_driver tps6594_pfsm_driver = { ··· 293 295 .name = "tps6594-pfsm", 294 296 }, 295 297 .probe = tps6594_pfsm_probe, 296 - .remove = tps6594_pfsm_remove, 298 + .remove_new = tps6594_pfsm_remove, 297 299 }; 298 300 299 301 module_platform_driver(tps6594_pfsm_driver);