Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

lkdtm/bugs: Adjust lkdtm_HUNG_TASK() to avoid tail call optimization

When testing with lkdtm_HUNG_TASK() and looking at the output, I
expected to see lkdtm_HUNG_TASK() in the stack crawl but it wasn't
there. Instead, the top function on at least some devices was
schedule() due to tail call optimization.

Let's do two things to help here:
1. We'll mark this as "__noreturn". On GCC at least this is documented
to prevent tail call optimization. The docs [1] say "In order to
preserve backtraces, GCC will never turn calls to noreturn
functions into tail calls."
2. We'll add a BUG_ON(1) at the end which means that schedule() is no
longer a tail call. Note that this is potentially important because
if we _did_ end up returning from schedule() due to some weird
issue then we'd potentially be violating the "noreturn" that we
told the compiler about. BUG is the right thing to do here.

[1] https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240122164935.2.I26e8f68c312824fcc80c19d4e91de2d2bef958f0@changeid
Signed-off-by: Kees Cook <keescook@chromium.org>

authored by

Douglas Anderson and committed by
Kees Cook
6dde3569 84022cff

+2 -1
+2 -1
drivers/misc/lkdtm/bugs.c
··· 294 294 __release(&lock_me_up); 295 295 } 296 296 297 - static void lkdtm_HUNG_TASK(void) 297 + static void __noreturn lkdtm_HUNG_TASK(void) 298 298 { 299 299 set_current_state(TASK_UNINTERRUPTIBLE); 300 300 schedule(); 301 + BUG_ON(1); 301 302 } 302 303 303 304 static volatile unsigned int huge = INT_MAX - 2;