tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: usb: enable the work after stop usbnet by ip down/up

Oleksij reported that:
The smsc95xx driver fails after one down/up cycle, like this:
$ nmcli device set enu1u1 managed no
$ p a a 10.10.10.1/24 dev enu1u1
$ ping -c 4 10.10.10.3
$ ip l s dev enu1u1 down
$ ip l s dev enu1u1 up
$ ping -c 4 10.10.10.3
The second ping does not reach the host. Networking also fails on other interfaces.

Enable the work by replacing the disable_work_sync() with cancel_work_sync().

[Jun Miao: completely write the commit changelog]

Fixes: 2c04d279e857 ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Signed-off-by: Jun Miao <jun.miao@intel.com>
Link: https://patch.msgid.link/20250708081653.307815-1-jun.miao@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Zqiang and committed by
Jakub Kicinski 6dfcbd7d 3b932976

+2 -2
+2 -2
drivers/net/usb/usbnet.c
··· 861 861 /* deferred work (timer, softirq, task) must also stop */ 862 862 dev->flags = 0; 863 863 timer_delete_sync(&dev->delay); 864 - disable_work_sync(&dev->bh_work); 864 + cancel_work_sync(&dev->bh_work); 865 865 cancel_work_sync(&dev->kevent); 866 866 867 867 /* We have cyclic dependencies. Those calls are needed 868 868 * to break a cycle. We cannot fall into the gaps because 869 869 * we have a flag 870 870 */ 871 - disable_work_sync(&dev->bh_work); 871 + cancel_work_sync(&dev->bh_work); 872 872 timer_delete_sync(&dev->delay); 873 873 cancel_work_sync(&dev->kevent); 874 874