Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
sunrpc/svc: use store_release_wake_up()
svc_thread_init_status() contains an open-coded
store_release_wake_up(). It is cleaner to use that function directly
rather than needing to remember the barrier.
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
authored by
NeilBrown
and committed by
Chuck Lever
6e1d75f7
935fee5d
+1
-6
+1
-6
include/linux/sunrpc/svc.h
+1
-6
include/linux/sunrpc/svc.h
···
327
327
*/
328
328
static inline void svc_thread_init_status(struct svc_rqst *rqstp, int err)
329
329
{
330
-
rqstp->rq_err = err;
331
-
/* memory barrier ensures assignment to error above is visible before
332
-
* waitqueue_active() test below completes.
333
-
*/
334
-
smp_mb();
335
-
wake_up_var(&rqstp->rq_err);
330
+
store_release_wake_up(&rqstp->rq_err, err);
336
331
if (err)
337
332
kthread_exit(1);
338
333
}