Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests: drv-net: psp: fix test flakes from racy connection close

There is a bug in assoc_sk_only_mismatch() and
assoc_sk_only_mismatch_tx() that creates a race condition which
triggers test flakes in later test cases e.g. data_send_bad_key().

The problem is that the client uses the "conn clr" rpc to setup a data
connection with psp_responder, but never uses a matching "data close"
rpc. This creates a race condition where if the client can queue
another data sock request, like in data_send_bad_key(), before the
server can accept the old connection from the backlog we end up in a
situation where we have two connections in the backlog: one for the
closed connection we have received a FIN for, and one for the new PSP
connection which is expecting to do key exchange.

From there the server pops the closed connection from the backlog, but
the data_send_bad_key() test case in psp.py hangs waiting to perform
key exchange.

The fix is to properly use _conn_close, which fill force the server to
remove the closed connection from the backlog before sending the RPC
ack to the client.

Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
Link: https://patch.msgid.link/20260127-psp-flaky-test-v1-1-13403e390af3@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Daniel Zahka and committed by
Jakub Kicinski
70de4674 701b40f8

+2
+2
tools/testing/selftests/drivers/net/psp.py
··· 266 266 the_exception = cm.exception 267 267 ksft_eq(the_exception.nl_msg.extack['bad-attr'], ".dev-id") 268 268 ksft_eq(the_exception.nl_msg.error, -errno.EINVAL) 269 + _close_conn(cfg, s) 269 270 270 271 271 272 def assoc_sk_only_mismatch_tx(cfg): ··· 284 283 the_exception = cm.exception 285 284 ksft_eq(the_exception.nl_msg.extack['bad-attr'], ".dev-id") 286 285 ksft_eq(the_exception.nl_msg.error, -errno.EINVAL) 286 + _close_conn(cfg, s) 287 287 288 288 289 289 def assoc_sk_only_unconn(cfg):