tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/imagination: Check for NULL struct dev_pm_domain_list

While dev_pm_domain_detach_list() itself contains the necessary NULL check,
the access to struct dev_pm_domain_list->num_pds does not and thus faults
on devices with <=1 power domains (where the struct dev_pm_domain_list
machinery is skipped for simplicity).

This can be reproduced on AM625, which produces the following log[1]:

[ 10.820056] powervr fd00000.gpu: Direct firmware load for powervr/rogue_33.15.11.3_v1.fw failed with error -2
[ 10.831903] powervr fd00000.gpu: [drm] *ERROR* failed to load firmware powervr/rogue_33.15.11.3_v1.fw (err=-2)
...
[ 10.844023] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000018
...
[ 11.090162] Call trace:
[ 11.092600] pvr_power_domains_fini+0x18/0xa0 [powervr] (P)
[ 11.098218] pvr_probe+0x100/0x14c [powervr]
[ 11.102505] platform_probe+0x5c/0xa4

Fixes: e19cc5ab347e3 ("drm/imagination: Use dev_pm_domain_attach_list()")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/r/c353fdef-9ccd-4a11-a527-ab4a792d8e70@sirena.org.uk/ [1]
Tested-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>
Link: https://patch.msgid.link/20260227-single-domain-power-fixes-v1-1-d37ba0825f7c@imgtec.com
Signed-off-by: Matt Coster <matt.coster@imgtec.com>

Matt Coster 713ec926 fca11428

+4 -2
+4 -2
drivers/gpu/drm/imagination/pvr_power.c
··· 668 668 { 669 669 struct pvr_device_power *pvr_power = &pvr_dev->power; 670 670 671 - int i = (int)pvr_power->domains->num_pds - 1; 671 + if (!pvr_power->domains) 672 + goto out; 672 673 673 - while (--i >= 0) 674 + for (int i = (int)pvr_power->domains->num_pds - 2; i >= 0; --i) 674 675 device_link_del(pvr_power->domain_links[i]); 675 676 676 677 dev_pm_domain_detach_list(pvr_power->domains); 677 678 678 679 kfree(pvr_power->domain_links); 679 680 681 + out: 680 682 *pvr_power = (struct pvr_device_power){ 0 }; 681 683 }