Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
selftests: drv-net: clarify linters and frameworks in README
Minor clarifications in the README:
- call out what linters we expect to be clean
- make it clear that by "frameworks" we mean code under lib/
not just factoring code out in the same file
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+8
-2
+8
-2
tools/testing/selftests/drivers/net/README.rst
+8
-2
tools/testing/selftests/drivers/net/README.rst
···
211
211
212
212
Test files should be relatively self contained. The libraries should
213
213
only include very core or non-trivial code.
214
-
It may be tempting to "factor out" the common code, but fight that urge.
215
-
Library code increases the barrier of entry, and complexity in general.
214
+
It may be tempting to "factor out" the common code to lib/py/, but fight that
215
+
urge. Library code increases the barrier of entry, and complexity in general.
216
216
217
217
Avoid mixing test code and boilerplate
218
218
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
···
289
289
@ksft_variants(_gro_variants())
290
290
def test(cfg, mode, protocol):
291
291
pass
292
+
293
+
Linters
294
+
~~~~~~~
295
+
296
+
We expect clean ``ruff check`` and ``pylint --disable=R``.
297
+
The code should be clean, avoid disabling pylint warnings explicitly!
292
298
293
299
Running tests CI-style
294
300
======================