tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: proximity: sx9500: make use of regmap_clear_bits(), regmap_set_bits()

Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-38-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Trevor Gamblin and committed by
Jonathan Cameron 734ecf98 3b8ec239

+6 -6
+6 -6
drivers/iio/proximity/sx9500.c
··· 209 209 /* Bit is already active, nothing to do. */ 210 210 return 0; 211 211 212 - return regmap_update_bits(data->regmap, reg, bitmask, bitmask); 212 + return regmap_set_bits(data->regmap, reg, bitmask); 213 213 } 214 214 215 215 static int sx9500_dec_users(struct sx9500_data *data, int *counter, ··· 220 220 /* There are more users, do not deactivate. */ 221 221 return 0; 222 222 223 - return regmap_update_bits(data->regmap, reg, bitmask, 0); 223 + return regmap_clear_bits(data->regmap, reg, bitmask); 224 224 } 225 225 226 226 static int sx9500_inc_chan_users(struct sx9500_data *data, int chan) ··· 795 795 int i, ret; 796 796 unsigned int val; 797 797 798 - ret = regmap_update_bits(data->regmap, SX9500_REG_PROX_CTRL0, 799 - SX9500_CHAN_MASK, SX9500_CHAN_MASK); 798 + ret = regmap_set_bits(data->regmap, SX9500_REG_PROX_CTRL0, 799 + SX9500_CHAN_MASK); 800 800 if (ret < 0) 801 801 return ret; 802 802 ··· 815 815 } 816 816 817 817 out: 818 - regmap_update_bits(data->regmap, SX9500_REG_PROX_CTRL0, 819 - SX9500_CHAN_MASK, 0); 818 + regmap_clear_bits(data->regmap, SX9500_REG_PROX_CTRL0, 819 + SX9500_CHAN_MASK); 820 820 return ret; 821 821 } 822 822