Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
usb: gadget: lpc32xx_udc: Remove NULL check of list_entry()
list_entry() will never return a NULL pointer, thus remove the
check.
Signed-off-by: Yuesong Li <liyuesong@vivo.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/20240821085245.25348-1-liyuesong@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
authored by
Yuesong Li
and committed by
Greg Kroah-Hartman
7393bf34
e24ed5e2
+30
-37
+30
-37
drivers/usb/gadget/udc/lpc32xx_udc.c
+30
-37
drivers/usb/gadget/udc/lpc32xx_udc.c
···
1487
1487
req = list_entry(ep0->queue.next, struct lpc32xx_request,
1488
1488
queue);
1489
1489
1490
-
if (req) {
1491
-
if (req->req.length == 0) {
1492
-
/* Just dequeue request */
1493
-
done(ep0, req, 0);
1494
-
udc->ep0state = WAIT_FOR_SETUP;
1495
-
return 1;
1496
-
}
1490
+
if (req->req.length == 0) {
1491
+
/* Just dequeue request */
1492
+
done(ep0, req, 0);
1493
+
udc->ep0state = WAIT_FOR_SETUP;
1494
+
return 1;
1495
+
}
1497
1496
1498
-
/* Get data from FIFO */
1499
-
bufferspace = req->req.length - req->req.actual;
1500
-
if (bufferspace > ep0->ep.maxpacket)
1501
-
bufferspace = ep0->ep.maxpacket;
1497
+
/* Get data from FIFO */
1498
+
bufferspace = req->req.length - req->req.actual;
1499
+
if (bufferspace > ep0->ep.maxpacket)
1500
+
bufferspace = ep0->ep.maxpacket;
1502
1501
1503
-
/* Copy data to buffer */
1504
-
prefetchw(req->req.buf + req->req.actual);
1505
-
tr = udc_read_hwep(udc, EP_OUT, req->req.buf + req->req.actual,
1506
-
bufferspace);
1507
-
req->req.actual += bufferspace;
1502
+
/* Copy data to buffer */
1503
+
prefetchw(req->req.buf + req->req.actual);
1504
+
tr = udc_read_hwep(udc, EP_OUT, req->req.buf + req->req.actual,
1505
+
bufferspace);
1506
+
req->req.actual += bufferspace;
1508
1507
1509
-
if (tr < ep0->ep.maxpacket) {
1510
-
/* This is the last packet */
1511
-
done(ep0, req, 0);
1512
-
udc->ep0state = WAIT_FOR_SETUP;
1513
-
return 1;
1514
-
}
1508
+
if (tr < ep0->ep.maxpacket) {
1509
+
/* This is the last packet */
1510
+
done(ep0, req, 0);
1511
+
udc->ep0state = WAIT_FOR_SETUP;
1512
+
return 1;
1515
1513
}
1516
1514
1517
1515
return 0;
···
1960
1962
1961
1963
/* If there isn't a request waiting, something went wrong */
1962
1964
req = list_entry(ep->queue.next, struct lpc32xx_request, queue);
1963
-
if (req) {
1964
-
done(ep, req, 0);
1965
1965
1966
-
/* Start another request if ready */
1967
-
if (!list_empty(&ep->queue)) {
1968
-
if (ep->is_in)
1969
-
udc_ep_in_req_dma(udc, ep);
1970
-
else
1971
-
udc_ep_out_req_dma(udc, ep);
1972
-
} else
1973
-
ep->req_pending = 0;
1974
-
}
1966
+
done(ep, req, 0);
1967
+
1968
+
/* Start another request if ready */
1969
+
if (!list_empty(&ep->queue)) {
1970
+
if (ep->is_in)
1971
+
udc_ep_in_req_dma(udc, ep);
1972
+
else
1973
+
udc_ep_out_req_dma(udc, ep);
1974
+
} else
1975
+
ep->req_pending = 0;
1975
1976
}
1976
1977
1977
1978
···
1986
1989
#endif
1987
1990
1988
1991
req = list_entry(ep->queue.next, struct lpc32xx_request, queue);
1989
-
if (!req) {
1990
-
ep_err(ep, "DMA interrupt on no req!\n");
1991
-
return;
1992
-
}
1993
1992
dd = req->dd_desc_ptr;
1994
1993
1995
1994
/* DMA descriptor should always be retired for this call */