tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Bluetooth: hci_sync: Use cmd->num_cis instead of magic number

At the moment of the check, `cmd->num_cis` holds the value of 0x1f,
which is the max number of elements in the `cmd->cis[]` array at
declaration, which is 0x1f.

So, avoid using 0x1f directly, and instead use `cmd->num_cis`. Similarly
to this other patch[1].

Link: https://lore.kernel.org/linux-hardening/ZivaHUQyDDK9fXEk@neat/ [1]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

authored by

Gustavo A. R. Silva and committed by
Luiz Augusto von Dentz 73b2652c d6bb8782

+1 -1
+1 -1
net/bluetooth/hci_sync.c
··· 6556 6556 cis->cis_handle = cpu_to_le16(conn->handle); 6557 6557 aux_num_cis++; 6558 6558 6559 - if (aux_num_cis >= 0x1f) 6559 + if (aux_num_cis >= cmd->num_cis) 6560 6560 break; 6561 6561 } 6562 6562 cmd->num_cis = aux_num_cis;