tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

misc: fastrpc: Use of_reserved_mem_region_to_resource() for "memory-region"

Use the newly added of_reserved_mem_region_to_resource() function to
handle "memory-region" properties.

The error handling is a bit different. "memory-region" is optional, so
failed lookup is not an error. But then an error in
of_reserved_mem_lookup() is treated as an error. However, that
distinction is not really important. Either the region is available
and usable or it is not. So now, it is just
of_reserved_mem_region_to_resource() which is checked for an error.

Signed-off-by: "Rob Herring (Arm)" <robh@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srini@kernel.org>
Link: https://lore.kernel.org/r/20250703183455.2074215-1-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Rob Herring (Arm) and committed by
Greg Kroah-Hartman 73cca2a7 77e49c35

+7 -12
+7 -12
drivers/misc/fastrpc.c
··· 2262 2262 int i, err, domain_id = -1, vmcount; 2263 2263 const char *domain; 2264 2264 bool secure_dsp; 2265 - struct device_node *rmem_node; 2266 - struct reserved_mem *rmem; 2267 2265 unsigned int vmids[FASTRPC_MAX_VMIDS]; 2268 2266 2269 2267 err = of_property_read_string(rdev->of_node, "label", &domain); ··· 2304 2306 } 2305 2307 } 2306 2308 2307 - rmem_node = of_parse_phandle(rdev->of_node, "memory-region", 0); 2308 - if (domain_id == SDSP_DOMAIN_ID && rmem_node) { 2309 + if (domain_id == SDSP_DOMAIN_ID) { 2310 + struct resource res; 2309 2311 u64 src_perms; 2310 2312 2311 - rmem = of_reserved_mem_lookup(rmem_node); 2312 - if (!rmem) { 2313 - err = -EINVAL; 2314 - goto err_free_data; 2315 - } 2313 + err = of_reserved_mem_region_to_resource(rdev->of_node, 0, &res); 2314 + if (!err) { 2315 + src_perms = BIT(QCOM_SCM_VMID_HLOS); 2316 2316 2317 - src_perms = BIT(QCOM_SCM_VMID_HLOS); 2318 - 2319 - qcom_scm_assign_mem(rmem->base, rmem->size, &src_perms, 2317 + qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, 2320 2318 data->vmperms, data->vmcount); 2319 + } 2321 2320 2322 2321 } 2323 2322