Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

vfio/pci: Require vfio_device_ops.name

vfio-pci-core code makes use of the vfio_device_ops.name field in order
to set a default driver_override for VFs created on a user-owned PF.
This avoids default driver matching, which might otherwise bind those
VFs to native drivers.

The mechanism for this currently uses kasprintf(), which will set
driver_override to the literal "(null)" if name is NULL. This is
effective in sequestering the device, but presents a challenging debug
situation to differentiate driver_override being set to "(null)" versus
being NULL and interpreted as "(null)" via the sysfs show attribute.

There's also a tree-wide effort to convert to generic driver_override
support, where passing NULL will generate an error, resulting in a
WARN_ON without setting any driver_override.

All drivers making use of vfio-pci-core already set a driver name,
therefore by requiring this behavior, all of these corner cases are
rendered moot. This is expected to have no impact on current
in-kernel drivers.

Suggested-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Alex Williamson <alex.williamson@nvidia.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20260331202443.2598404-1-alex.williamson@nvidia.com
Signed-off-by: Alex Williamson <alex@shazbot.org>

authored by

Alex Williamson and committed by
Alex Williamson
7487d8db ad6ed97f

+4
+4
drivers/vfio/pci/vfio_pci_core.c
··· 2139 2139 if (WARN_ON(vdev != dev_get_drvdata(dev))) 2140 2140 return -EINVAL; 2141 2141 2142 + /* Drivers must set a name. Required for sequestering SR-IOV VFs */ 2143 + if (WARN_ON(!vdev->vdev.ops->name)) 2144 + return -EINVAL; 2145 + 2142 2146 if (pdev->hdr_type != PCI_HEADER_TYPE_NORMAL) 2143 2147 return -EINVAL; 2144 2148