tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amdgpu: Drop redundant syncobj handle limit checks in userq ioctls

Clang warns that comparing a __u16 value against 65536 is always false.

num_syncobj_handles is defined as __u16 in both the userq signal and
wait ioctl argument structs, so it can never exceed 65535. The checks
against AMDGPU_USERQ_MAX_HANDLES are therefore redundant and trigger
-Wtautological-constant-out-of-range-compare.

Fixes: Clang -Wtautological-constant-out-of-range-compare in userq
signal/wait ioctls

Fixes: d8e760b7996d ("drm/amdgpu: update type for num_syncobj_handles in drm_amdgpu_userq_signal")
Fixes: c561d2320492 ("drm/amdgpu: update type for num_syncobj_handles in drm_amdgpu_userq_wait")
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Srinivasan Shanmugam and committed by
Alex Deucher 750cbc4f 0d21084c

+2 -4
+2 -4
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
··· 479 479 if (!amdgpu_userq_enabled(dev)) 480 480 return -ENOTSUPP; 481 481 482 - if (args->num_syncobj_handles > AMDGPU_USERQ_MAX_HANDLES || 483 - args->num_bo_write_handles > AMDGPU_USERQ_MAX_HANDLES || 482 + if (args->num_bo_write_handles > AMDGPU_USERQ_MAX_HANDLES || 484 483 args->num_bo_read_handles > AMDGPU_USERQ_MAX_HANDLES) 485 484 return -EINVAL; 486 485 ··· 634 635 if (!amdgpu_userq_enabled(dev)) 635 636 return -ENOTSUPP; 636 637 637 - if (wait_info->num_syncobj_handles > AMDGPU_USERQ_MAX_HANDLES || 638 - wait_info->num_bo_write_handles > AMDGPU_USERQ_MAX_HANDLES || 638 + if (wait_info->num_bo_write_handles > AMDGPU_USERQ_MAX_HANDLES || 639 639 wait_info->num_bo_read_handles > AMDGPU_USERQ_MAX_HANDLES) 640 640 return -EINVAL; 641 641