tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: rockchip: Drop unused and broken CR0 macros

Two CTRLR0 macros are defined but never referenced, and both are wrong:

- CR0_XFM_MASK shifts by SPI_XFM_OFFSET, which does not exist anywhere
in the tree. The intended symbol is CR0_XFM_OFFSET.

- CR0_MTM_OFFSET is defined as 0x21, i.e. bit 33 of a 32-bit register.
The value is meaningless and the macro is unused.

Drop both. They can be re-introduced correctly when an actual user
appears.

Signed-off-by: John Madieu <john.madieu@gmail.com>
Link: https://patch.msgid.link/20260425092936.2590132-3-john.madieu@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

John Madieu and committed by
Mark Brown 76439787 b4683a23

-3
-3
drivers/spi/spi-rockchip.c
··· 98 98 #define CR0_FRF_MICROWIRE 0x2 99 99 100 100 #define CR0_XFM_OFFSET 18 101 - #define CR0_XFM_MASK (0x03 << SPI_XFM_OFFSET) 102 101 #define CR0_XFM_TR 0x0 103 102 #define CR0_XFM_TO 0x1 104 103 #define CR0_XFM_RO 0x2 ··· 107 108 #define CR0_OPM_TARGET 0x1 108 109 109 110 #define CR0_SOI_OFFSET 23 110 - 111 - #define CR0_MTM_OFFSET 0x21 112 111 113 112 /* Bit fields in SER, 2bit */ 114 113 #define SER_MASK 0x3