tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

xen: irqfd: Use _IOW instead of the internal _IOC() macro

_IOC() an internal helper that we should not use in driver code. In
particular, we got the data direction wrong here, which breaks a number
of tools, as having "_IOC_NONE" should never be paired with a nonzero
size.

Use _IOW() instead.

Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd")
Reported-by: Arnd Bergmann <arnd@kernel.org>
Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@app.fastmail.com/
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/599ca6f1b9dd2f0e6247ea37bee3ea6827404b6d.1697439990.git.viresh.kumar@linaro.org
Signed-off-by: Juergen Gross <jgross@suse.com>

authored by

Viresh Kumar and committed by
Juergen Gross 767e33ca 8dd765a5

+1 -1
+1 -1
include/uapi/xen/privcmd.h
··· 138 138 #define IOCTL_PRIVCMD_MMAP_RESOURCE \ 139 139 _IOC(_IOC_NONE, 'P', 7, sizeof(struct privcmd_mmap_resource)) 140 140 #define IOCTL_PRIVCMD_IRQFD \ 141 - _IOC(_IOC_NONE, 'P', 8, sizeof(struct privcmd_irqfd)) 141 + _IOW('P', 8, struct privcmd_irqfd) 142 142 143 143 #endif /* __LINUX_PUBLIC_PRIVCMD_H__ */