tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sysfs/cpu: Use DEVICE_ATTR_RO for nohz_full attribute

The /sys/devices/system/cpu/nohz_full file is a read-only attribute that
reports the CPUs configured for tickless operation (CONFIG_NO_HZ_FULL=y).

The current definition uses the generic DEVICE_ATTR macro, which
unnecessarily requires specifying the file mode (0444) and a NULL
store operation pointer.

This patch converts the definition to use the dedicated DEVICE_ATTR_RO
macro. This correctly expresses the read-only nature of the attribute,
removes the redundant mode field, and simplifies the code. As a related
cleanup, rename the show function from print_cpus_nohz_full() to the
standard nohz_full_show() for consistency with common sysfs attribute
naming conventions.

Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
Link: https://patch.msgid.link/20251011011830.6670-2-atomlin@atomlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Aaron Tomlin and committed by
Greg Kroah-Hartman 76987bac 382b1e8f

+4 -3
+4 -3
drivers/base/cpu.c
··· 301 301 static DEVICE_ATTR(isolated, 0444, print_cpus_isolated, NULL); 302 302 303 303 #ifdef CONFIG_NO_HZ_FULL 304 - static ssize_t print_cpus_nohz_full(struct device *dev, 305 - struct device_attribute *attr, char *buf) 304 + static ssize_t nohz_full_show(struct device *dev, 305 + struct device_attribute *attr, 306 + char *buf) 306 307 { 307 308 return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(tick_nohz_full_mask)); 308 309 } 309 - static DEVICE_ATTR(nohz_full, 0444, print_cpus_nohz_full, NULL); 310 + static DEVICE_ATTR_RO(nohz_full); 310 311 #endif 311 312 312 313 #ifdef CONFIG_CRASH_HOTPLUG