tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mfd: tps65219: Remove TPS65219_REG_TI_DEV_ID check

The chipid macro/variable and regmap_read function call is not needed
because the TPS65219_REG_TI_DEV_ID register value is not a consistent value
across TPS65219 PMIC config versions. Reading from the DEV_ID register
without a consistent value to compare it to isn't useful. There isn't a
way to verify the match data ID is the same ID read from the DEV_ID device
register. 0xF0 isn't a DEV_ID value consistent across TPS65219 NVM
configurations.

For TPS65215, there is a consistent value in bits 5-0 of the DEV_ID
register. However, there are other error checks in place within probe()
that apply to both PMICs rather than keeping this isolated check for one
PMIC.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
Link: https://lore.kernel.org/r/20250206173725.386720-4-s-ramamoorthy@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Shree Ramamoorthy and committed by
Lee Jones 76b58d51 5a004cf4

-7
-7
drivers/mfd/tps65219.c
··· 221 221 static int tps65219_probe(struct i2c_client *client) 222 222 { 223 223 struct tps65219 *tps; 224 - unsigned int chipid; 225 224 bool pwr_button; 226 225 int ret; 227 226 ··· 244 245 &tps->irq_data); 245 246 if (ret) 246 247 return ret; 247 - 248 - ret = regmap_read(tps->regmap, TPS65219_REG_TI_DEV_ID, &chipid); 249 - if (ret) { 250 - dev_err(tps->dev, "Failed to read device ID: %d\n", ret); 251 - return ret; 252 - } 253 248 254 249 ret = devm_mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, 255 250 tps65219_cells, ARRAY_SIZE(tps65219_cells),