Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

omapfb: add missing of_node_put after of_device_is_available

Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>

Fixes: f76ee892a99e6 ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

authored by

Julia Lawall and committed by
Bartlomiej Zolnierkiewicz
787a7923 36884ceb

+3 -1
+3 -1
drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
··· 193 193 194 194 dss = of_find_matching_node(NULL, omapdss_of_match); 195 195 196 - if (dss == NULL || !of_device_is_available(dss)) 196 + if (dss == NULL || !of_device_is_available(dss)) { 197 + of_node_put(dss); 197 198 return 0; 199 + } 198 200 199 201 omapdss_walk_device(dss, true); 200 202