Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

accel/habanalabs: convert timeouts to secs_to_jiffies()

Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
secs_to_jiffies(). As the value here is a multiple of 1000, use
secs_to_jiffies() instead of msecs_to_jiffies() to avoid the
multiplication

This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
the following Coccinelle rules:

@depends on patch@
expression E;
@@

-msecs_to_jiffies
+secs_to_jiffies
(E
- * \( 1000 \| MSEC_PER_SEC \)
)

Link: https://lkml.kernel.org/r/20250225-converge-secs-to-jiffies-part-two-v3-3-a43967e36c88@linux.microsoft.com
Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: Carlos Maiolino <cem@kernel.org>
Cc: Carlos Maiolino <cmaiolino@redhat.com>
Cc: Chris Mason <clm@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Maol <dlemoal@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>
Cc: David Sterba <dsterba@suse.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>
Cc: Dongsheng Yang <dongsheng.yang@easystack.cn>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frank Li <frank.li@nxp.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: James Bottomley <james.bottomley@HansenPartnership.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Julia Lawall <julia.lawall@inria.fr>
Cc: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Niklas Cassel <cassel@kernel.org>
Cc: Oded Gabbay <ogabbay@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Selvin Thyparampil Xavier <selvin.xavier@broadcom.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Shyam-sundar S-k <Shyam-sundar.S-k@amd.com>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Easwar Hariharan and committed by
Andrew Morton
78cf56f8 84c34d01

+4 -4
+1 -1
drivers/accel/habanalabs/common/command_submission.c
··· 2586 2586 cs_seq = args->in.seq; 2587 2587 2588 2588 timeout = flags & HL_CS_FLAGS_CUSTOM_TIMEOUT 2589 - ? msecs_to_jiffies(args->in.timeout * 1000) 2589 + ? secs_to_jiffies(args->in.timeout) 2590 2590 : hpriv->hdev->timeout_jiffies; 2591 2591 2592 2592 switch (cs_type) {
+1 -1
drivers/accel/habanalabs/common/debugfs.c
··· 1403 1403 return rc; 1404 1404 1405 1405 if (value) 1406 - hdev->timeout_jiffies = msecs_to_jiffies(value * 1000); 1406 + hdev->timeout_jiffies = secs_to_jiffies(value); 1407 1407 else 1408 1408 hdev->timeout_jiffies = MAX_SCHEDULE_TIMEOUT; 1409 1409
+1 -1
drivers/accel/habanalabs/common/device.c
··· 2091 2091 dev_dbg(hdev->dev, "Device is going to be hard-reset in %u sec unless being released\n", 2092 2092 hdev->device_release_watchdog_timeout_sec); 2093 2093 schedule_delayed_work(&hdev->device_release_watchdog_work.reset_work, 2094 - msecs_to_jiffies(hdev->device_release_watchdog_timeout_sec * 1000)); 2094 + secs_to_jiffies(hdev->device_release_watchdog_timeout_sec)); 2095 2095 hdev->reset_info.watchdog_active = 1; 2096 2096 out: 2097 2097 spin_unlock(&hdev->reset_info.lock);
+1 -1
drivers/accel/habanalabs/common/habanalabs_drv.c
··· 386 386 hdev->fw_comms_poll_interval_usec = HL_FW_STATUS_POLL_INTERVAL_USEC; 387 387 388 388 if (tmp_timeout) 389 - hdev->timeout_jiffies = msecs_to_jiffies(tmp_timeout * MSEC_PER_SEC); 389 + hdev->timeout_jiffies = secs_to_jiffies(tmp_timeout); 390 390 else 391 391 hdev->timeout_jiffies = MAX_SCHEDULE_TIMEOUT; 392 392