tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ena: Remove ena_select_queue

Avoid the following warnings by removing the ena_select_queue() function
and rely on the net core to do the queue selection, The issue happen
when an skb received from an interface with more queues than ena is
forwarded to the ena interface.

[ 1176.159959] eth0 selects TX queue 11, but real number of TX queues is 8
[ 1176.863976] eth0 selects TX queue 14, but real number of TX queues is 8
[ 1180.767877] eth0 selects TX queue 14, but real number of TX queues is 8
[ 1188.703742] eth0 selects TX queue 14, but real number of TX queues is 8

Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Kamal Heib <kheib@redhat.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Kamal Heib and committed by
David S. Miller 78e886ba 6d47302a

-17
-17
drivers/net/ethernet/amazon/ena/ena_netdev.c
··· 2689 2689 return NETDEV_TX_OK; 2690 2690 } 2691 2691 2692 - static u16 ena_select_queue(struct net_device *dev, struct sk_buff *skb, 2693 - struct net_device *sb_dev) 2694 - { 2695 - u16 qid; 2696 - /* we suspect that this is good for in--kernel network services that 2697 - * want to loop incoming skb rx to tx in normal user generated traffic, 2698 - * most probably we will not get to this 2699 - */ 2700 - if (skb_rx_queue_recorded(skb)) 2701 - qid = skb_get_rx_queue(skb); 2702 - else 2703 - qid = netdev_pick_tx(dev, skb, NULL); 2704 - 2705 - return qid; 2706 - } 2707 - 2708 2692 static void ena_config_host_info(struct ena_com_dev *ena_dev, struct pci_dev *pdev) 2709 2693 { 2710 2694 struct device *dev = &pdev->dev; ··· 2865 2881 .ndo_open = ena_open, 2866 2882 .ndo_stop = ena_close, 2867 2883 .ndo_start_xmit = ena_start_xmit, 2868 - .ndo_select_queue = ena_select_queue, 2869 2884 .ndo_get_stats64 = ena_get_stats64, 2870 2885 .ndo_tx_timeout = ena_tx_timeout, 2871 2886 .ndo_change_mtu = ena_change_mtu,