Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
phy: qcom-qmp-pcie-msm8996: drop unused pcs_misc handling
The MSM8996 QMP PHY driver does not use the PCS_MISC IO region (and
neither do the DT binding specify it) so remove the corresponding code
from the driver.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20220916102340.11520-8-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
authored by
Johan Hovold
and committed by
Vinod Koul
79a03925
a5d6b1ac
-14
-14
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
-14
drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c
···
202
202
int rx_tbl_num;
203
203
const struct qmp_phy_init_tbl *pcs_tbl;
204
204
int pcs_tbl_num;
205
-
const struct qmp_phy_init_tbl *pcs_misc_tbl;
206
-
int pcs_misc_tbl_num;
207
205
208
206
/* clock ids to be requested */
209
207
const char * const *clk_list;
···
238
240
* @tx: iomapped memory space for lane's tx
239
241
* @rx: iomapped memory space for lane's rx
240
242
* @pcs: iomapped memory space for lane's pcs
241
-
* @pcs_misc: iomapped memory space for lane's pcs_misc
242
243
* @pipe_clk: pipe clock
243
244
* @index: lane index
244
245
* @qmp: QMP phy to which this lane belongs
···
251
254
void __iomem *tx;
252
255
void __iomem *rx;
253
256
void __iomem *pcs;
254
-
void __iomem *pcs_misc;
255
257
struct clk *pipe_clk;
256
258
unsigned int index;
257
259
struct qcom_qmp *qmp;
···
519
523
void __iomem *tx = qphy->tx;
520
524
void __iomem *rx = qphy->rx;
521
525
void __iomem *pcs = qphy->pcs;
522
-
void __iomem *pcs_misc = qphy->pcs_misc;
523
526
void __iomem *status;
524
527
unsigned int mask, val, ready;
525
528
int ret;
···
546
551
cfg->rx_tbl_num, 1);
547
552
548
553
qmp_pcie_msm8996_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
549
-
550
-
qmp_pcie_msm8996_configure(pcs_misc, cfg->regs, cfg->pcs_misc_tbl,
551
-
cfg->pcs_misc_tbl_num);
552
554
553
555
/*
554
556
* Pull out PHY from POWER DOWN state.
···
785
793
/*
786
794
* Get memory resources for each phy lane:
787
795
* Resources are indexed as: tx -> 0; rx -> 1; pcs -> 2.
788
-
* For dual lane PHYs: tx2 -> 3, rx2 -> 4, pcs_misc (optional) -> 5
789
-
* For single lane PHYs: pcs_misc (optional) -> 3.
790
796
*/
791
797
qphy->tx = devm_of_iomap(dev, np, 0, NULL);
792
798
if (IS_ERR(qphy->tx))
···
797
807
qphy->pcs = devm_of_iomap(dev, np, 2, NULL);
798
808
if (IS_ERR(qphy->pcs))
799
809
return PTR_ERR(qphy->pcs);
800
-
801
-
qphy->pcs_misc = devm_of_iomap(dev, np, 3, NULL);
802
-
if (IS_ERR(qphy->pcs_misc))
803
-
dev_vdbg(dev, "PHY pcs_misc-reg not used\n");
804
810
805
811
qphy->pipe_clk = devm_get_clk_from_child(dev, np, NULL);
806
812
if (IS_ERR(qphy->pipe_clk)) {