tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: mediatek: Fix double pm_runtime_disable in remove functions

Both mt8195-afe-pcm and mt8365-afe-pcm drivers use devm_pm_runtime_enable()
in probe function, which automatically calls pm_runtime_disable() on device
removal via devres mechanism. However, the remove callbacks explicitly call
pm_runtime_disable() again, resulting in double pm_runtime_disable() calls.

Fix by removing the redundant pm_runtime_disable() calls from remove
functions, letting the devres framework handle it automatically.

Fixes: 2ca0ec01d49c ("ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe")
Fixes: e1991d102bc2 ("ASoC: mediatek: mt8365: Add the AFE driver support")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251020170440.585-1-vulab@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Haotian Zhang and committed by
Mark Brown 79a6f2da 6b03360f

-2
-1
sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
··· 3176 3176 3177 3177 static void mt8195_afe_pcm_dev_remove(struct platform_device *pdev) 3178 3178 { 3179 - pm_runtime_disable(&pdev->dev); 3180 3179 if (!pm_runtime_status_suspended(&pdev->dev)) 3181 3180 mt8195_afe_runtime_suspend(&pdev->dev); 3182 3181 }
-1
sound/soc/mediatek/mt8365/mt8365-afe-pcm.c
··· 2238 2238 2239 2239 mt8365_afe_disable_top_cg(afe, MT8365_TOP_CG_AFE); 2240 2240 2241 - pm_runtime_disable(&pdev->dev); 2242 2241 if (!pm_runtime_status_suspended(&pdev->dev)) 2243 2242 mt8365_afe_runtime_suspend(&pdev->dev); 2244 2243 }