tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: mediatek: mt8188: avoid uninitialized variable use

The 'msk' variable has no initialization:

sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: error: variable 'msk' is uninitialized when used here [-Werror,-Wuninitialized]
311 | msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
| ^~~

Set it to zero before the loop.

Fixes: c1e42ec04197 ("ASoC: mediatek: mt8188: Add support for DMIC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://patch.msgid.link/20250227131939.1040168-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Arnd Bergmann and committed by
Mark Brown 79ed408b a54a659f

+1
+1
sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
··· 307 307 switch (event) { 308 308 case SND_SOC_DAPM_PRE_PMU: 309 309 /* request fifo soft rst */ 310 + msk = 0; 310 311 for (i = dmic_num; i >= DMIC0; i--) 311 312 msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i); 312 313