tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

media: nxp: imx8-isi: fix v4l2-compliance test errors

Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m
device fails on the MMAP streaming tests, with the following messages:

fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY
fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node)

Apparently, the driver does not properly set the field member of
vb2_v4l2_buffer struct, returning the default V4L2_FIELD_ANY value which
is against the guidelines.

Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20240924103304.124085-1-laurentiu.palcu@oss.nxp.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

authored by

Laurentiu Palcu and committed by
Hans Verkuil 7b12ab05 2762eab6

+3
+3
drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c
··· 861 861 const struct mxc_isi_format_info *info, 862 862 const struct v4l2_pix_format_mplane *pix) 863 863 { 864 + struct vb2_v4l2_buffer *v4l2_buf = to_vb2_v4l2_buffer(vb2); 864 865 unsigned int i; 865 866 866 867 for (i = 0; i < info->mem_planes; i++) { ··· 875 874 876 875 vb2_set_plane_payload(vb2, i, size); 877 876 } 877 + 878 + v4l2_buf->field = pix->field; 878 879 879 880 return 0; 880 881 }