tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crash: remove an unused argument from reserve_crashkernel_generic()

cmdline argument is not used in reserve_crashkernel_generic() so remove
it. Correspondingly, all the callers have been updated as well.

No functional change intended.

Link: https://lkml.kernel.org/r/20250131113830.925179-3-sourabhjain@linux.ibm.com
Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Mahesh Salgaonkar <mahesh@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Sourabh Jain and committed by
Andrew Morton 7b54a96f 9986fb51

+17 -26
+2 -4
arch/arm64/mm/init.c
··· 98 98 { 99 99 unsigned long long low_size = 0; 100 100 unsigned long long crash_base, crash_size; 101 - char *cmdline = boot_command_line; 102 101 bool high = false; 103 102 int ret; 104 103 105 104 if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) 106 105 return; 107 106 108 - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), 107 + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), 109 108 &crash_size, &crash_base, 110 109 &low_size, &high); 111 110 if (ret) 112 111 return; 113 112 114 - reserve_crashkernel_generic(cmdline, crash_size, crash_base, 115 - low_size, high); 113 + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); 116 114 } 117 115 118 116 static phys_addr_t __init max_zone_phys(phys_addr_t zone_limit)
+2 -3
arch/loongarch/kernel/setup.c
··· 259 259 int ret; 260 260 unsigned long long low_size = 0; 261 261 unsigned long long crash_base, crash_size; 262 - char *cmdline = boot_command_line; 263 262 bool high = false; 264 263 265 264 if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) 266 265 return; 267 266 268 - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), 267 + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), 269 268 &crash_size, &crash_base, &low_size, &high); 270 269 if (ret) 271 270 return; 272 271 273 - reserve_crashkernel_generic(cmdline, crash_size, crash_base, low_size, high); 272 + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); 274 273 } 275 274 276 275 static void __init fdt_setup(void)
+2 -4
arch/riscv/mm/init.c
··· 1396 1396 { 1397 1397 unsigned long long low_size = 0; 1398 1398 unsigned long long crash_base, crash_size; 1399 - char *cmdline = boot_command_line; 1400 1399 bool high = false; 1401 1400 int ret; 1402 1401 1403 1402 if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) 1404 1403 return; 1405 1404 1406 - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), 1405 + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), 1407 1406 &crash_size, &crash_base, 1408 1407 &low_size, &high); 1409 1408 if (ret) 1410 1409 return; 1411 1410 1412 - reserve_crashkernel_generic(cmdline, crash_size, crash_base, 1413 - low_size, high); 1411 + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); 1414 1412 } 1415 1413 1416 1414 void __init paging_init(void)
+2 -4
arch/x86/kernel/setup.c
··· 472 472 static void __init arch_reserve_crashkernel(void) 473 473 { 474 474 unsigned long long crash_base, crash_size, low_size = 0; 475 - char *cmdline = boot_command_line; 476 475 bool high = false; 477 476 int ret; 478 477 479 478 if (!IS_ENABLED(CONFIG_CRASH_RESERVE)) 480 479 return; 481 480 482 - ret = parse_crashkernel(cmdline, memblock_phys_mem_size(), 481 + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), 483 482 &crash_size, &crash_base, 484 483 &low_size, &high); 485 484 if (ret) ··· 489 490 return; 490 491 } 491 492 492 - reserve_crashkernel_generic(cmdline, crash_size, crash_base, 493 - low_size, high); 493 + reserve_crashkernel_generic(crash_size, crash_base, low_size, high); 494 494 } 495 495 496 496 static struct resource standard_io_resources[] = {
+5 -6
include/linux/crash_reserve.h
··· 32 32 #define CRASH_ADDR_HIGH_MAX memblock_end_of_DRAM() 33 33 #endif 34 34 35 - void __init reserve_crashkernel_generic(char *cmdline, 36 - unsigned long long crash_size, 37 - unsigned long long crash_base, 38 - unsigned long long crash_low_size, 39 - bool high); 35 + void __init reserve_crashkernel_generic(unsigned long long crash_size, 36 + unsigned long long crash_base, 37 + unsigned long long crash_low_size, 38 + bool high); 40 39 #else 41 - static inline void __init reserve_crashkernel_generic(char *cmdline, 40 + static inline void __init reserve_crashkernel_generic( 42 41 unsigned long long crash_size, 43 42 unsigned long long crash_base, 44 43 unsigned long long crash_low_size,
+4 -5
kernel/crash_reserve.c
··· 375 375 return 0; 376 376 } 377 377 378 - void __init reserve_crashkernel_generic(char *cmdline, 379 - unsigned long long crash_size, 380 - unsigned long long crash_base, 381 - unsigned long long crash_low_size, 382 - bool high) 378 + void __init reserve_crashkernel_generic(unsigned long long crash_size, 379 + unsigned long long crash_base, 380 + unsigned long long crash_low_size, 381 + bool high) 383 382 { 384 383 unsigned long long search_end = CRASH_ADDR_LOW_MAX, search_base = 0; 385 384 bool fixed_base = false;