tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/mmu_gather: clean up the stale code comment

In commit d7f861b9c43a ("mm/mmu_gather: add __tlb_remove_folio_pages()"),
helper function __tlb_remove_folio_pages_size() was added. And based on
the helper, wrapper functions __tlb_remove_folio_pages() and
__tlb_remove_page_size() are created and used by upper level functions.

So let's update the code comment to reflect the current code about
tlb_remove_page()/tlb_remove_page_size(), etc.

Link: https://lkml.kernel.org/r/20250211034348.39531-2-bhe@redhat.com
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Baoquan He and committed by
Andrew Morton 7bd1fa0d 1d23b940

+10 -11
+10 -11
include/asm-generic/tlb.h
··· 67 67 * 68 68 * See also MMU_GATHER_TABLE_FREE and MMU_GATHER_RCU_TABLE_FREE. 69 69 * 70 - * - tlb_remove_page() / __tlb_remove_page() 71 - * - tlb_remove_page_size() / __tlb_remove_page_size() 72 - * - __tlb_remove_folio_pages() 70 + * - tlb_remove_page() / tlb_remove_page_size() 71 + * - __tlb_remove_folio_pages() / __tlb_remove_page_size() 72 + * - __tlb_remove_folio_pages_size() 73 73 * 74 - * __tlb_remove_page_size() is the basic primitive that queues a page for 75 - * freeing. __tlb_remove_page() assumes PAGE_SIZE. Both will return a 76 - * boolean indicating if the queue is (now) full and a call to 77 - * tlb_flush_mmu() is required. 74 + * __tlb_remove_folio_pages_size() is the basic primitive that queues pages 75 + * for freeing. It will return a boolean indicating if the queue is (now) 76 + * full and a call to tlb_flush_mmu() is required. 78 77 * 79 78 * tlb_remove_page() and tlb_remove_page_size() imply the call to 80 79 * tlb_flush_mmu() when required and has no return value. 81 80 * 82 - * __tlb_remove_folio_pages() is similar to __tlb_remove_page(), however, 83 - * instead of removing a single page, remove the given number of consecutive 84 - * pages that are all part of the same (large) folio: just like calling 85 - * __tlb_remove_page() on each page individually. 81 + * __tlb_remove_folio_pages() is similar to __tlb_remove_page_size(), 82 + * however, instead of removing a single page, assume PAGE_SIZE and remove 83 + * the given number of consecutive pages that are all part of the 84 + * same (large) folio. 86 85 * 87 86 * - tlb_change_page_size() 88 87 *