Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/ast: Group DDC init code by data structure
Reorder the code to set up the DDC channel by data structure, so
that each data structure's init is in a separate block: first the
bit algo then the i2c adapter. Makes the code more readable. No
functional changes.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240403103325.30457-3-tzimmermann@suse.de
+8
-8
+8
-8
drivers/gpu/drm/ast/ast_ddc.c
+8
-8
drivers/gpu/drm/ast/ast_ddc.c
···
145
145
return ERR_PTR(-ENOMEM);
146
146
ddc->ast = ast;
147
147
148
-
adapter = &ddc->adapter;
149
-
adapter->owner = THIS_MODULE;
150
-
adapter->dev.parent = dev->dev;
151
-
i2c_set_adapdata(adapter, ddc);
152
-
snprintf(adapter->name, sizeof(adapter->name), "AST DDC bus");
153
-
154
148
bit = &ddc->bit;
155
-
bit->udelay = 20;
156
-
bit->timeout = usecs_to_jiffies(2200);
157
149
bit->data = ddc;
158
150
bit->setsda = ast_ddc_algo_bit_data_setsda;
159
151
bit->setscl = ast_ddc_algo_bit_data_setscl;
···
153
161
bit->getscl = ast_ddc_algo_bit_data_getscl;
154
162
bit->pre_xfer = ast_ddc_algo_bit_data_pre_xfer;
155
163
bit->post_xfer = ast_ddc_algo_bit_data_post_xfer;
164
+
bit->udelay = 20;
165
+
bit->timeout = usecs_to_jiffies(2200);
156
166
167
+
adapter = &ddc->adapter;
168
+
adapter->owner = THIS_MODULE;
157
169
adapter->algo_data = bit;
170
+
adapter->dev.parent = dev->dev;
171
+
snprintf(adapter->name, sizeof(adapter->name), "AST DDC bus");
172
+
i2c_set_adapdata(adapter, ddc);
173
+
158
174
ret = i2c_bit_add_bus(adapter);
159
175
if (ret) {
160
176
drm_err(dev, "Failed to register bit i2c\n");