Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/ast: Fix comment on modeset lock
The ast driver protects the commit tail against concurrent reads
of the display modes by acquiring a lock. The comment is misleading
as the lock is not released in atomic_flush, but at the end of the
commit-tail helper. Rewrite the comment.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 1fe182154984 ("drm/ast: Acquire I/O-register lock in atomic_commit_tail function")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.2+
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20250324094520.192974-2-tzimmermann@suse.de
+3
-3
+3
-3
drivers/gpu/drm/ast/ast_mode.c
+3
-3
drivers/gpu/drm/ast/ast_mode.c
···
939
939
940
940
/*
941
941
* Concurrent operations could possibly trigger a call to
942
-
* drm_connector_helper_funcs.get_modes by trying to read the
943
-
* display modes. Protect access to I/O registers by acquiring
944
-
* the I/O-register lock. Released in atomic_flush().
942
+
* drm_connector_helper_funcs.get_modes by reading the display
943
+
* modes. Protect access to registers by acquiring the modeset
944
+
* lock.
945
945
*/
946
946
mutex_lock(&ast->modeset_lock);
947
947
drm_atomic_helper_commit_tail(state);