Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/i915/backlight: Provide clear description on how backlight level is controlled
Currently it takes us multiple log prints to arrive at the conclusion
on how we are actually controlling backlight level. Make the logging
concise.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://patch.msgid.link/20260302040613.3324049-8-suraj.kandpal@intel.com
+14
-5
+14
-5
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+14
-5
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
···
368
368
return aux ? "DPCD" : "PWM";
369
369
}
370
370
371
+
static const char *backlight_unit_str(struct intel_panel *panel)
372
+
{
373
+
if (panel->backlight.edp.vesa.info.luminance_set)
374
+
return "NITS";
375
+
else if (panel->backlight.edp.vesa.info.aux_set)
376
+
return "Brightness %";
377
+
else
378
+
return "PWM";
379
+
}
380
+
371
381
static void
372
382
intel_dp_aux_write_panel_luminance_override(struct intel_connector *connector)
373
383
{
···
552
542
dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_enable ||
553
543
panel->backlight.edp.vesa.info.luminance_set));
554
544
drm_dbg_kms(display->drm,
555
-
"[CONNECTOR:%d:%s] AUX VESA backlight level is controlled through %s\n",
545
+
"[CONNECTOR:%d:%s] AUX VESA backlight level is controlled through %s using %s values\n",
556
546
connector->base.base.id, connector->base.name,
557
-
dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_set));
547
+
dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_set ||
548
+
panel->backlight.edp.vesa.info.luminance_set),
549
+
backlight_unit_str(panel));
558
550
559
551
if (!panel->backlight.edp.vesa.info.aux_set ||
560
552
!panel->backlight.edp.vesa.info.aux_enable) {
···
579
567
}
580
568
panel->backlight.level = intel_dp_aux_vesa_get_backlight(connector, 0);
581
569
panel->backlight.enabled = panel->backlight.level != 0;
582
-
drm_dbg_kms(display->drm,
583
-
"[CONNECTOR:%d:%s] AUX VESA Nits backlight level is controlled through DPCD\n",
584
-
connector->base.base.id, connector->base.name);
585
570
} else if (panel->backlight.edp.vesa.info.aux_set) {
586
571
panel->backlight.max = panel->backlight.edp.vesa.info.max;
587
572
panel->backlight.min = 0;