tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

regulator: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144721.1544756-1-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Rob Herring and committed by
Mark Brown 7dda20c9 4eb6678a

+7 -7
+4 -4
drivers/regulator/bd71815-regulator.c
··· 201 201 202 202 data = container_of(desc, struct bd71815_regulator, desc); 203 203 204 - if (of_find_property(np, "rohm,dvs-run-voltage", NULL) || 205 - of_find_property(np, "rohm,dvs-suspend-voltage", NULL) || 206 - of_find_property(np, "rohm,dvs-lpsr-voltage", NULL) || 207 - of_find_property(np, "rohm,dvs-snvs-voltage", NULL)) { 204 + if (of_property_present(np, "rohm,dvs-run-voltage") || 205 + of_property_present(np, "rohm,dvs-suspend-voltage") || 206 + of_property_present(np, "rohm,dvs-lpsr-voltage") || 207 + of_property_present(np, "rohm,dvs-snvs-voltage")) { 208 208 ret = regmap_read(cfg->regmap, desc->vsel_reg, &val); 209 209 if (ret) 210 210 return ret;
+1 -1
drivers/regulator/fixed.c
··· 151 151 of_property_read_u32(np, "startup-delay-us", &config->startup_delay); 152 152 of_property_read_u32(np, "off-on-delay-us", &config->off_on_delay); 153 153 154 - if (of_find_property(np, "vin-supply", NULL)) 154 + if (of_property_present(np, "vin-supply")) 155 155 config->input_supply = "vin"; 156 156 157 157 return config;
+1 -1
drivers/regulator/gpio-regulator.c
··· 220 220 regtype); 221 221 } 222 222 223 - if (of_find_property(np, "vin-supply", NULL)) 223 + if (of_property_present(np, "vin-supply")) 224 224 config->input_supply = "vin"; 225 225 226 226 return config;
+1 -1
drivers/regulator/pwm-regulator.c
··· 334 334 335 335 memcpy(&drvdata->desc, &pwm_regulator_desc, sizeof(drvdata->desc)); 336 336 337 - if (of_find_property(np, "voltage-table", NULL)) 337 + if (of_property_present(np, "voltage-table")) 338 338 ret = pwm_regulator_init_table(pdev, drvdata); 339 339 else 340 340 ret = pwm_regulator_init_continuous(pdev, drvdata);